Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update aiohttp>=3.7.4 in requirements #19872

Merged
merged 2 commits into from
Apr 27, 2022
Merged

chore: Update aiohttp>=3.7.4 in requirements #19872

merged 2 commits into from
Apr 27, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Apr 27, 2022

SUMMARY

Removing dependencies issue with aiohttps by update to 3.7.4 or higher

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh closed this Apr 27, 2022
@hughhhh hughhhh reopened this Apr 27, 2022
@codecov
Copy link

codecov bot commented Apr 27, 2022 •
edited
Loading

Codecov Report

Merging #19872 (1596f6c) into master (e061955) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19872      +/-   ##
==========================================
+ Coverage   66.51%   66.54%   +0.02%     
==========================================
  Files        1690     1691       +1     
  Lines       64614    64815     +201     
  Branches     6655     6655              
==========================================
+ Hits        42978    43131     +153     
- Misses      19936    19984      +48     
  Partials     1700     1700
Flag Coverage Δ
hive 52.91% <ø> (+0.21%) ⬆️
mysql 81.91% <ø> (-0.04%) ⬇️
postgres 81.96% <ø> (-0.04%) ⬇️
presto 52.76% <ø> (+0.22%) ⬆️
python 82.39% <ø> (-0.04%) ⬇️
sqlite 81.73% <ø> (-0.04%) ⬇️
unit 47.99% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/migrations/shared/utils.py 36.17% <0.00%> (-39.39%) ⬇️
superset/tables/models.py 67.53% <0.00%> (-32.47%) ⬇️
superset/columns/models.py 96.29% <0.00%> (-3.71%) ⬇️
superset/datasets/models.py 96.42% <0.00%> (-3.58%) ⬇️
superset/views/base.py 73.77% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/presto.py 88.70% <0.00%> (-0.33%) ⬇️
superset/sql_parse.py 97.07% <0.00%> (-0.31%) ⬇️
superset/constants.py 100.00% <0.00%> (ø)
superset/queries/api.py 100.00% <0.00%> (ø)
superset/dashboards/api.py 92.73% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e061955...1596f6c. Read the comment docs.

@hughhhh hughhhh mentioned this pull request Apr 27, 2022
Closed
9 tasks
@hughhhh hughhhh merged commit 481ccfe into apache:master Apr 27, 2022
hughhhh added a commit to hve-labs/superset that referenced this pull request May 11, 2022
@hughhhh
chore: Update aiohttp>=3.7.4 in requirements (apache#19872)
12c66a9 
* update

* lets see
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@hughhhh @philipher29
chore: Update aiohttp>=3.7.4 in requirements (apache#19872)
5d53c0c 
* update

* lets see
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAfghahi AAfghahi AAfghahi approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughhhh @AAfghahi @mistercrunch